Skip to content

Ignore __lbheartbeat__ requests in Sentry #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 12, 2023
Merged

Ignore __lbheartbeat__ requests in Sentry #363

merged 4 commits into from
Jan 12, 2023

Conversation

@grahamalama
Copy link
Contributor

@grahamalama grahamalama commented Jan 12, 2023

Closes #215

In this PR, we:

  • use dynamic sampling to ignore __lbheartbeat__ requests in Sentry. The sentry_traces_sample_rateenvironment variable is still present so that we can control the global sample rate of non-__lbheartbeat__ requests.
  • update the way we initialize Sentry to be in line with current documentation
  • rename test_main to test_app. main.py was renamed to app.py, but we didn't rename the complementary test module at that time

@grahamalama grahamalama requested a review from a team as a code owner January 12, 2023 15:57
bsieber-mozilla
bsieber-mozilla approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@bsieber-mozilla bsieber-mozilla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@grahamalama grahamalama merged commit 033685c into main Jan 12, 2023
@grahamalama grahamalama deleted the ignore-lbheartbeat-requests branch January 12, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bsieber-mozilla bsieber-mozilla bsieber-mozilla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

internal-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Do we need so many Sentry transactions?

3 participants

@grahamalama @bsieber-mozilla