Fix #344: add request id to logs #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamalama
reviewed
Feb 10, 2023
Contributor
grahamalama
left a comment
grahamalama
left a comment
There was a problem hiding this comment.
I notice we use uuid4 as a unique request id in case we don't get the Nginx header, which makes sense.
However, I also noticed that nginx uses a "16 byte hexadecimal number" as their request id (docs).
Should we mirror that by using secrets.token_hex(16)?
grahamalama
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #344
X-Request-Idfrom$requestidhttps://github.com/mozilla-services/cloudops-infra/pull/4694