Skip to content

Do not use hard-coded url in tests #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2023
Merged

Do not use hard-coded url in tests #405

merged 1 commit into from
Feb 13, 2023

Conversation

@leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Feb 13, 2023

With a custom .env file the tests would fail. It's annoying when developing and trying things on real servers at the same time

@leplatrem leplatrem requested a review from a team as a code owner February 13, 2023 11:10
@leplatrem leplatrem added the enhancement New feature or request label Feb 13, 2023
@leplatrem leplatrem merged commit e9db0d4 into main Feb 13, 2023
@leplatrem leplatrem deleted the fix-tests-custom-env branch February 13, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@grahamalama grahamalama grahamalama approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leplatrem @grahamalama