Fix #475, #382: Fix lookup of actions when tag contains dash

[bsieber-mozilla]

Resolves: #475

Updates to lookup_action logic-- instead of constructing tags from the whiteboard, then trying to see which tag exists as an action. In this commit we attempt to use the action.whiteboard_tag as the element which must exist within the bug.whiteboard element--iterating through the actions, and acting on the first action that applies to the bug. The whiteboard_tag presented in the action must be contained within the bug’s whiteboard field with a prefix of [

As is: the functionality is working with this new process for action confirmation.

• Fix logs so that when ActionNotFound is raised and used later for processing, this makes sense in the messaging

This PR ultimately allows for [exact-match-or-partial-matchs-123]:

• data-eng-platform and data-eng-quality would be able to coexist and map to separate processes

[leplatrem]

Bryan, could you explain the reason behind this change?
It may be a good opportunity to start a docs/adrs/ folder, and add a brief one for this.

Side nitpicking: there's no issue associated to this ;)

[bsieber-mozilla]

Bryan, could you explain the reason behind this change?
It may be a good opportunity to start a docs/adrs/ folder, and add a brief one for this.

We have an action that currently is impossible to map whiteboard tags to with the current .split process that occurs on the - character (in the bug whiteboard parsing methods):

jira-bugzilla-integration/jbi/models.py

Lines 264 to 267 in 846d69a

	for whiteboard in self.get_whiteboard_as_list():
	first_tag = whiteboard.strip().lower().split(sep="-", maxsplit=1)[0]
	if first_tag:
	converted_list.append(first_tag)

Currently any whiteboard tag that comes in with: [remote-settings] gets assigned the action_tag remote as the lookup key in the action dictionary.

Reversing the lookup to find the action_tag inside the whiteboard_tag without parsing the whiteboard_tag as heavily; enables this action as well as future actions to have "-"s in them.

In the later commits, I added brackets_required to the Action model; the default behavior of having the brackets required can now be disabled per action. This has been implicit and is now likely a process many users follow.

This PR now makes [this behavior] something we are not requiring, but are defaulting to at this time.

[bsieber-mozilla]

Side nitpicking: there's no issue associated to this ;)

Ahh, upon second reading this made sense; I thought you were mentioning there's no issue with the code.. but there's no github issue associated with this change, is the conclusion I just came to... I made #475 from the DENG comment, forcing a user to adjust their whiteboard processing.

I'll add the above comment in regards to [remote-settings] to the gh issue as well