Skip to content

Conversation

@grahamalama
Copy link
Contributor

@grahamalama grahamalama commented May 8, 2023

This makes it so that we're dealing with client objects directly, rather than an InstrumentedClient. This makes things like autocomplete, docstrings, and typing work a bit better.

Before:
Screenshot 2023-05-08 at 2 51 05 PM
Screenshot 2023-05-08 at 2 48 26 PM

After:
Screenshot 2023-05-08 at 2 50 49 PM
Screenshot 2023-05-08 at 2 49 45 PM

This make it so that we're dealing with a Client object directly, rather
than an instrumented client. This improves developer ergonomics like
autocomplete, docstrings, and typing.
@grahamalama grahamalama requested a review from a team as a code owner May 8, 2023 19:24
@grahamalama grahamalama added the enhancement New feature or request label May 8, 2023
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way more elegant 💯

@grahamalama grahamalama merged commit c349d25 into main May 9, 2023
@grahamalama grahamalama deleted the instrumentation-decorator branch May 9, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants