Ref #520: add typing for action parameters #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamalama
approved these changes
May 22, 2023
grahamalama
added a commit
that referenced
this pull request
May 26, 2023
This reverts commit c178e30.
This was referenced May 26, 2023
leplatrem
added a commit
that referenced
this pull request
May 29, 2023
* Revert "Ref #520: add typing for action parameters (#523)" This reverts commit c178e30. * Include action module name in raised exceptions * action_factory fixture doesn't return an Action * Remove test Bugzilla action We don't include clients in the action object anymore, so this test class isn't useful * Add typing for steps * Rework some tests `test_modules` - Instead of a test class, assert that the default action serializes - Rework tests for asserting valid and invalid values for bugzilla_user_id - use registered `action_factory` instead of import where possible * use `.get()` for param guard clauses * Add tests for _all_projects_components_exist * Add guards for getting params in steps --------- Co-authored-by: Mathieu Leplatre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.