Skip to content

Conversation

@leplatrem
Copy link
Contributor

Fix #578

@leplatrem leplatrem requested a review from a team as a code owner June 12, 2023 14:41
Copy link
Contributor

@grahamalama grahamalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

We should probably also remove these references to private bug:

def webhook_create_private_example() -> BugzillaWebhookRequest:

# Private bugs don't include the changes field in the event, but the
# field names are in the routing key.
if self.routing_key is not None and self.routing_key[0:11] == "bug.modify:":
return self.routing_key[11:].split(",")

and maybe I still missed some references.

We should probably also make a note about private comments. Is it possible for a private comment to exist on a public bug? If so, do we want to be syncing that private data?

@leplatrem leplatrem requested a review from grahamalama June 13, 2023 14:34
@leplatrem leplatrem merged commit 46bfa35 into main Jun 13, 2023
@leplatrem leplatrem deleted the 578-remove-private-mentions branch June 13, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove references to private bug syncing in JBI

3 participants