Start process to improve Jira logging #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamalama
changed the title
leplatrem
approved these changes
Nov 21, 2023
Contributor
leplatrem
left a comment
leplatrem
left a comment
There was a problem hiding this comment.
👌
(you can ignore any of my comments if they don't make sense to you)
`test_create_jira_issue_returns_list` -> `test_create_jira_issue_when_list_is_returned` Co-authored-by: Mathieu Leplatre <[email protected]>
grahamalama
commented
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #645
Adds / modifies logging for a few Jira service methods
The important things we want to check here:
rideverywhere, as this is what will help us correlate logs for an action workflowThis PR is getting a temperature-check for the logging / testing patterns before I continue further