Change method for fetching visible projects and issue types in __heartbeat__ #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `spy` method this package provides is super useful
grahamalama
force-pushed
the
more-efficent-heartbeat-code
branch
from
7c99daf to
7a4591a
Compare
grahamalama
changed the title
grahamalama
force-pushed
the
more-efficent-heartbeat-code
branch
2 times, most recently
from
31c7605 to
0d08b75
Compare
In v6.3.6, we bumped atlassian-python-api from 3.41.4. That bump included a [PR](atlassian-api/atlassian-python-api#1270) which changed the way library fetched projects. This somehow affected our project when we fetched visible projects and issue types in the heartbeat. We never fully determined the root cause, but the while loop in the linked PR was suspect. In this commit, we make further improvements to the code that's involved in the heartbeat to make it more efficent. Note that one of the tradeoffs we made for now was hardcoding the maximum number of projects that may be configured at 50. This is due to the way we fetch issue types by project. This is something that we can fix in the future, but is not a problem that we need to solve for now since we only have 26 project configured.
grahamalama
force-pushed
the
more-efficent-heartbeat-code
branch
from
0d08b75 to
415bed8
Compare
alexcottner
reviewed
Dec 11, 2023
alexcottner
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the commit message for fd46133:
In v6.3.6, we bumped atlassian-python-api from 3.41.4. That bump included a PR which changed the way the library fetched projects. This somehow affected our project when we fetched visible projects and issue types in the heartbeat. We never fully determined the root cause, but the while loop in the linked PR was suspect.
In this commit, we make further improvements to the code that's involved in the heartbeat to make it more efficient.
Note that one of the tradeoffs we made for now was hardcoding the maximum number of projects that may be configured at 50. This is due to the way we fetch issue types by project. This is something that we can fix in the future, but is not a problem that we need to solve for now since we only have 26 projects configured.