Skip to content

Conversation

@Mossop
Copy link
Member

@Mossop Mossop commented Jul 8, 2022

Currently we retrieve the full bug in router and then again in the action. We should just do this once and pass it through to the action.

@Mossop Mossop requested a review from a team as a code owner July 8, 2022 13:45
Currently we retrieve the full bug in router and then again in the
action. Here a property is added to BugzillaWebhookRequest to get the
full bug when needed and cache it.
@Mossop
Copy link
Member Author

Mossop commented Jul 11, 2022

I ended up having to move getbug_as_bugzilla_object into BugzillaWebhookRequest to solve a cyclic dependency issue.

Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leplatrem leplatrem merged commit 01b5b48 into mozilla:main Jul 11, 2022
@Mossop Mossop deleted the lookup-once branch July 11, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants