Remove top-level actions config key
#84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamalama
changed the title
actions config key
bsieber-mozilla
approved these changes
Jul 8, 2022
Contributor
bsieber-mozilla
left a comment
bsieber-mozilla
left a comment
There was a problem hiding this comment.
Minor suggestion; overall LGTM
Includes the config/ directory and example config in tests
Remove the need for the top-level `actions` key in the action config This, among other things, removes the need for the Actions.all() method
leplatrem
approved these changes
Jul 11, 2022
| def all(self): | ||
| """Return mapping of all actions""" | ||
| return self.actions | ||
| return self.__root__.get(tag.lower()) if tag else None |
Contributor
There was a problem hiding this comment.
Shouldn't we move this to __getitem__() ?
Contributor
Author
There was a problem hiding this comment.
I think they're different right?
__getitem__ is for actions['devtest'], which will throw a KeyError if the item is missing
vs actions.get("devtest") which will return None if the key doesn't exist.
Contributor
There was a problem hiding this comment.
Yeah, but one could rely on the other to match the actions[item.lower()] and actions[None] behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we had a top-level actions key in project config. This seemed somewhat unnecessary since there aren't any other config objects besides actions. That meant that any time we wanted to access actions, we'd need to do
actions_instance.actions.<whatever>.This PR removes the top-level
actionskey in config and modifies theActionsPydantic model to give it a__root__property to contain the actions.