Use orjson for serialising responses. #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a bug we embed the response of the bugzilla update_bugs call into the repsonse. This contains a datetime instance which is not serialisable by the default JSONResponse and so currently JBI throws an internal server error back to Bugzilla which then repeats the request a second time which is effectively ignored because by then the bug has the see_also field set. This switches to ORJSONResponse which can serialise datetime and a few other types correctly.
leplatrem
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a bug we embed the response of the bugzilla update_bugs
call into the repsonse. This contains a datetime instance which is not
serialisable by the default JSONResponse and so currently JBI throws
an internal server error back to Bugzilla which then repeats the
request a second time which is effectively ignored because by then the
bug has the see_also field set.
This switches to ORJSONResponse which can serialise datetime and a
few other types correctly.