-
Notifications
You must be signed in to change notification settings - Fork 26
Align test & lint #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bsieber-mozilla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM--thanks for the consolidation! 👍
|
Thanks for the approval @bsieber-mozilla. @leplatrem, looking for your review as well since I built on top of your initial PR. |
Running this from a shell script seemed to keep pre-commit happy
Run directly in Github Actions VM
This should fail if it can't run
|
(I should really get out of the habit of my rebase on |
leplatrem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 🎉
nit: the Github jobs are called lint-build and test-build, which was relevant when we were testing containers. Now they can be rename lint and test IMO
leplatrem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized we exclude tests from certain checks.
When including tests in isort we face the issue I was having, where black unwraps and isort wraps back.
Something I just had to do that fixed this:
I think when we do that, isort will respect the "black" profile in |
Chatted with @leplatrem about #81, and I added some more changes on top of that PR here.
The idea with this PR is that
infra/lint.shandinfra/test.share the "source of truth" for how we want to run linting and tests respectively. We then use these scripts in precommit, make, Github Actions, and wherever else we want to run tests and linting.For Github Actions, we also now run linting and tests directly in the action runner, rather than running through Docker. This resulted in a speed-up of the checks.
Fixes #79
Fixes #67