Fix #645: Switch log messages to INFO level #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
changed the title
alexcottner
reviewed
Feb 27, 2024
alexcottner
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #645
Debug level seemed like a good idea, because in the end, that's why we need those log messages, to debug stuff.
But debug messages are not enabled in default deployment config, and do not seem to be collected in our Logging panel.
We could ask ops to reconfigure it the service/logging (for the second time), but I believe that using info is a reasonable fix to this problem.
The trafic is low enough, these messages are globally very concise compared to ridiculous amount of logs coming from k8s