Skip to content

Conversation

@dmose
Copy link
Member

@dmose dmose commented Mar 12, 2024

The OMC team would like to add the syncing of story points without changing anything else. Our current configuration doesn't have a steps stanza, and so is presumably just using the defaults (is that correct?).

In any case, I couldn't see a way to say "use the defaults except with these two changes", which was the semantics I really wanted, so I cloned the defaults from the code itself, which (I think) should get me almost the same thing, except that it doesn't continue to get new defaults as steps get added to the defaults over time. Correct?

Assuming those things are correct, I'd love to get this reviewed...

CC @aminomancer

@dmose dmose requested a review from a team as a code owner March 12, 2024 22:13
@github-actions github-actions bot added the configuration Changes to JBI action configuration label Mar 12, 2024
@alexcottner
Copy link
Contributor

Our current configuration doesn't have a steps stanza, and so is presumably just using the defaults (is that correct?).

Correct, if you are missing steps or one of the child groups, defaults will be used. See this doc for details.

@dmose
Copy link
Member Author

dmose commented Mar 13, 2024

I don't seem to have the privs to merge this PR, even though it's been approved. What needs to happen next?

@alexcottner alexcottner merged commit 5ab8ff0 into mozilla:main Mar 13, 2024
@leplatrem
Copy link
Contributor

I just tagged a version with the commits of this PR, the changes should be rolled out to stage/prod soon. Check out the #jbi channel for updates 🙏

@dmose
Copy link
Member Author

dmose commented Mar 15, 2024

Thanks; it seems to be working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

configuration Changes to JBI action configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants