Use pytest-dotenv #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are provided through pytest now
bsieber-mozilla
approved these changes
Jul 12, 2022
Contributor
bsieber-mozilla
left a comment
bsieber-mozilla
left a comment
There was a problem hiding this comment.
LGTM. Thanks for this consolidation for the env vars!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pytest-dotenv and uses it to configure environment variables for testing. This means that we don't need to remember to set them in places like Docker containers, Github actions, etc.
It also renames the action workflow files for linting and testing, since they don't use the Docker container anymore as of b8dc0b5