Adding queue to bugzilla webhook route #939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcottner
changed the title
leplatrem
reviewed
Apr 11, 2024
grahamalama
reviewed
Apr 11, 2024
leplatrem
approved these changes
Apr 16, 2024
Contributor
leplatrem
left a comment
leplatrem
left a comment
There was a problem hiding this comment.
I would say that we should let the queue crash, and let fastapi return a 500 and send a sentry, instead of catching all exceptions and reraising a httperror manually
grahamalama
reviewed
Apr 16, 2024
grahamalama
reviewed
Apr 16, 2024
grahamalama
reviewed
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to finish the retry queue work by adding logic to the
bugzilla_webhookrouteMuch of this was copied from @leplatrem 's draft PR here.