Skip to content

Conversation

@leplatrem
Copy link
Contributor

Fix #958

@leplatrem leplatrem requested a review from a team as a code owner April 19, 2024 09:51
@leplatrem leplatrem added the enhancement New feature or request label Apr 19, 2024
Copy link
Contributor

@grahamalama grahamalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some questions about metrics. Maybe instead of including the metrics in each log line, we can add like a "retry run id" (with a better name), and then include that in each log line. Then we can quickly find all of the logs for a particular retry run (with the metrics appearing on the last line as a summary for that run)

@alexcottner
Copy link
Contributor

I'd like to see something added to execute_or_queue in runner.py as well. If execute_action throws an error, we should log an error with the event identifier so we can alert.

@leplatrem leplatrem merged commit 5a14f89 into main Apr 22, 2024
@leplatrem leplatrem deleted the 958-add-more-logging-fields branch April 22, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more context fields to queue exception logs

4 participants