Fix #969: force message on HTTPError when empty #970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
force-pushed
the
969-insightful-http-error
branch
from
95c69b0 to
a75b9b0
Compare
grahamalama
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #969
Note for reviewers: The location of the test is debatable. I wanted to have the equivalent of a end-to-end test, to make sure we end-up receiving the details in the queue item.
Note 2: I'm not super proud of the trick that consists in replacing the
argsattribute with our own string, but I couldn't come up with a better idea. I thought to move the inspection code to the queue class, but we wouldn't benefit from the changes in Sentry...Note 3: Didn't focus on Bugzilla HTTP errors since we don't raise anything when bug details / comments cannot be fetched (we have a catch all in runner). See #971
Open to revisit any choice based on your feedback 🙏