Skip to content

Update/dockerflow 2024.04.2, separate queue checks #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 26, 2024
Merged

Update/dockerflow 2024.04.2, separate queue checks #974

merged 10 commits into from
Apr 26, 2024

Conversation

@alexcottner
Copy link
Contributor

@alexcottner alexcottner commented Apr 24, 2024 •
edited
Loading

This PR aims to resolve #972.

Steps taken:

  1. Updated dockerflow to 2024.04.2.
  2. Enabled async checks
  3. Refactored queue heartbeat checks to separate concerns
  4. Adjusted unit tests
  5. Adjusted queue so it only reads folders that are whole numbers (thanks @leplatrem )
    • note: Tried to do this with glob at first, but I don't think there is a way to do this with glob.

@alexcottner alexcottner changed the title Update/dockerflow 2024.04.2 WIP - Update/dockerflow 2024.04.2 Apr 24, 2024
@alexcottner alexcottner added the bug Something isn't working label Apr 24, 2024
@alexcottner alexcottner changed the title WIP - Update/dockerflow 2024.04.2 Update/dockerflow 2024.04.2, separate queue checks Apr 25, 2024
@alexcottner alexcottner marked this pull request as ready for review April 25, 2024 16:03
@alexcottner alexcottner requested a review from a team as a code owner April 25, 2024 16:03
@alexcottner alexcottner mentioned this pull request Apr 25, 2024
Closed
leplatrem
leplatrem reviewed Apr 25, 2024
View reviewed changes
leplatrem
leplatrem approved these changes Apr 26, 2024
View reviewed changes
@alexcottner alexcottner changed the title Update/dockerflow 2024.04.2, separate queue checks Update/dockerflow 2024.04.2, seperate queue checks Apr 26, 2024
@alexcottner alexcottner changed the title Update/dockerflow 2024.04.2, seperate queue checks Update/dockerflow 2024.04.2, separate queue checks Apr 26, 2024
@alexcottner alexcottner merged commit 3bc7c04 into main Apr 26, 2024
@alexcottner alexcottner deleted the update/dockerflow-2024.04.2 branch April 26, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leplatrem leplatrem leplatrem approved these changes

@grahamalama grahamalama Awaiting requested review from grahamalama

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Queue dockerflow check error

3 participants

@alexcottner @leplatrem