Skip to content

Logging a warning when we try to remove a file but cannot find it #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Logging a warning when we try to remove a file but cannot find it #985

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0281889
Logging a warning when we try to remove a file but cannot find it
alexcottner Apr 30, 2024
a40845d
Update jbi/queue.py
alexcottner Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions jbi/queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,12 @@ async def put(self, item: QueueItem):
async def remove(self, bug_id: int, identifier: str):
bug_dir = self.location / f"{bug_id}"
item_path = bug_dir / (identifier + ".json")
item_path.unlink(missing_ok=True)
logger.debug("Removed %s from queue for bug %s", identifier, bug_id)
try:
logger.debug("Removing %s from queue for bug %s", identifier, bug_id)
item_path.unlink()
except FileNotFoundError as exc:
logger.warning("Could not delete missing item at path %s", str(item_path), exc)

if not any(bug_dir.iterdir()):
bug_dir.rmdir()
logger.debug("Removed directory for bug %s", bug_id)
Expand Down