Skip to content

Move the popup annotation in the DOM just after the element triggering it #20004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Move the popup annotation in the DOM just after the element triggering it #20004

merged 1 commit into from
Jun 16, 2025

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman requested a review from a team as a code owner June 10, 2025 16:58
flodolo
flodolo approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@flodolo flodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a possible alternative, which I think it's clearer. With the current text, is the comment within the popup, or is the comment about the popup?

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a014a794f27dc73/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d612d137402dfdb/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a014a794f27dc73/output.txt

Total script time: 57.39 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

timvandermeij
timvandermeij approved these changes Jun 15, 2025
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with the comment addressed. Thanks!

@calixteman
Copy link
Contributor Author

/botio test

1 similar comment
@calixteman
Copy link
Contributor Author

/botio test

@mozilla mozilla deleted a comment from moz-tools-bot Jun 16, 2025
@mozilla mozilla deleted a comment from moz-tools-bot Jun 16, 2025
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9367ae4b31ff840/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9f9b1b2dfe2f63f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/9f9b1b2dfe2f63f/output.txt

Total script time: 31.83 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/9367ae4b31ff840/output.txt

Total script time: 56.75 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@calixteman calixteman merged commit 802808c into mozilla:master Jun 16, 2025
9 checks passed
@calixteman calixteman deleted the move_popup_dom branch June 16, 2025 21:11
@timvandermeij
Copy link
Contributor

Thanks! I also like the updated solution better because it's simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

@flodolo flodolo flodolo approved these changes

Assignees
No one assigned
Labels
accessibility annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixteman @moz-tools-bot @timvandermeij @flodolo