Skip to content

Conversation

borjamunozf
Copy link
Contributor

@borjamunozf borjamunozf commented Jun 17, 2025

Hello!

I realized that compilers arguments/flags for gcc like the mentioned above are being used in the hash_key function. This means that strategies for handling the absolute paths to relatives regarding debug info or in similar fashion that involves passing a dynamic value into the argument depending of the builder origin will create a different hash key.

From my point of view, these kind of arguments should not affect the computer hash key at all:

  • -_fdebug-prefix-map=${PWD}=.
  • -fmacro-prefix-map
  • ffile-prefix-map
  • fdebug-compilation-dir

A naive change could just include a non-hashable list of args that should be skipped or not considered into the hash key.

@borjamunozf borjamunozf force-pushed the feature/donthashdebugprefixargs branch from 6b250b9 to 080280a Compare June 17, 2025 16:34
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.60%. Comparing base (9fd99c7) to head (ad5d821).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2409      +/-   ##
==========================================
+ Coverage   71.58%   71.60%   +0.01%     
==========================================
  Files          65       65              
  Lines       36372    36398      +26     
==========================================
+ Hits        26037    26061      +24     
- Misses      10335    10337       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sylvestre sylvestre force-pushed the feature/donthashdebugprefixargs branch from a7122f0 to bac9935 Compare June 20, 2025 16:18
@borjamunozf borjamunozf marked this pull request as ready for review June 24, 2025 07:52
@sylvestre sylvestre force-pushed the feature/donthashdebugprefixargs branch from bac9935 to 85cffb7 Compare September 22, 2025 12:10
@sylvestre sylvestre force-pushed the feature/donthashdebugprefixargs branch from 85cffb7 to ad5d821 Compare September 25, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants