Add missing unsafe block in ThinVec::is_singleton with gecko-ffi #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was removed in 6e51160 which seems to have been an accident. Fixes mozilla#42
Collaborator
|
Sorry about that, and sorry for the delay! 0.2.11 released |
Collaborator
|
wait holdup is this a toolchain version thing
|
Collaborator
|
OH! It's because it's an extern static in prod but a local static in tests... that sucks! |
Collaborator
|
see #45 for a drive-by elaboration on what went wrong (also 0.2.12 released with better capacity overflow checking) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was removed in 6e51160 which seems to have been an accident.
Fixes #42