fix CryptographyECKey.verify failure #115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an invalid signature is passed to sigdecode_string, an AssertionError is raise. This assertion error was being passed up through CryptographyECKey.verify, rather than CryptographyECKey.verify catching the error and returning False, as required by the Key.verify API.
This was referenced Dec 25, 2018
Contributor
Author
|
Closing in favor of #117 as it removes the need for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an invalid signature is passed to
sigdecode_string, anAssertionErroris raise.This assertion error was being passed up through
CryptographyECKey.verify, ratherthan
CryptographyECKey.verifycatching the error and returning False, as requiredby the
Key.verifyAPI.NOTE: This fixes the
pyca/cryptographybackend isolation tests, but thebaseandcompatibilitytest runs are still expected to fail.