Allow bytes secret #187
Merged
Allow bytes secret #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
=======================================
Coverage 93.49% 93.49%
=======================================
Files 16 16
Lines 1723 1723
=======================================
Hits 1611 1611
Misses 112 112
Continue to review full report at Codecov.
|
|
Thanks for resolving this! Please could you push a new release to PyPI - the current version is missing this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71.
Resolves #72.
Resolves #74.
Closes #93 (supercedes).
Resolves #126.
This PR makes key handling more robust by properly handling keys that are dictionaries and (more importantly) keys that are not dictionaries.