Skip to content

fix(android): menu shows when disabled set in some cases #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix(android): menu shows when disabled set in some cases #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions android/src/main/java/com/mpiannucci/reactnativecontextmenu/ContextMenuView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,15 @@ public ContextMenuView(final Context context) {
gestureDetector = new GestureDetector(context, new GestureDetector.SimpleOnGestureListener() {
@Override
public boolean onSingleTapConfirmed(MotionEvent e) {
if (dropdownMenuMode) {
if (dropdownMenuMode && !disabled) {
contextMenu.show();
}
return super.onSingleTapConfirmed(e);
}

@Override
public void onLongPress(MotionEvent e) {
if (!dropdownMenuMode) {
if (!dropdownMenuMode && !disabled) {
contextMenu.show();
}
}
Expand Down Expand Up @@ -107,8 +107,6 @@ public void setActions(@Nullable ReadableArray actions) {
Menu menu = contextMenu.getMenu();
menu.clear();

if (disabled) { return; }

for (int i = 0; i < actions.size(); i++) {
ReadableMap action = actions.getMap(i);
@Nullable Drawable systemIcon = getResourceWithName(getContext(), action.getString("systemIcon"));
Expand Down