Skip to content

Conversation

@mudler
Copy link
Owner

@mudler mudler commented Nov 16, 2024

Description

Seems the hipblas binary still have AVX and other CPU flags that might be problematic on old HW. As hipblas is reserved in cases of running inference on GPU, CPU optimizations aren't needed and actually just causes sigsev when running binaries.

Notes for Reviewers

See: #3367 (comment)

Signed commits

  • Yes, I signed my commits.

@mudler mudler changed the title chore(hipblas): disable avx flags when accellerated bins are used fix(hipblas): disable avx flags when accellerated bins are used Nov 16, 2024
@mudler mudler added the bug Something isn't working label Nov 16, 2024
@netlify
Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 8ddd01c
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/6738a483b31ac600081e586c
😎 Deploy Preview https://deploy-preview-4167--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chris-hatton
Copy link

Thanks so much for this @mudler - looking forward to confirming the fix as soon as possible.

@mudler mudler merged commit e898e0b into master Nov 17, 2024
32 of 33 checks passed
@mudler mudler deleted the fix/hipblas_avx branch November 17, 2024 09:24
@chris-hatton
Copy link

chris-hatton commented Nov 18, 2024

@mudler I've tried again with image localai/localai:master-hipblas, which I think should now contain the fix, following merge of #3367

...unfortunately it's the same result. Using docker image inspect localai/localai:master-hipblas to confirm the image ID:

[
    {
        "Id": "sha256:7c9ffb9f8d249df6d068308adc9e8c1e5b183845031d6ff976b811ffe9106dee",
        "RepoTags": [
            "localai/localai:master-hipblas"
        ],
        "RepoDigests": [
            "localai/localai@sha256:a5dac979e4cac52729619c98daec793537d16c9ecc430d07c1a04cd6628973b7"
        ],
        "Parent": "",
        "Comment": "buildkit.dockerfile.v0",
        "Created": "2024-11-17T14:46:58.000365484Z",
        ...

...exit code 132 (Invalid OpCode).

@mudler
Copy link
Owner Author

mudler commented Nov 20, 2024

@mudler I've tried again with image localai/localai:master-hipblas, which I think should now contain the fix, following merge of #3367

...unfortunately it's the same result. Using docker image inspect localai/localai:master-hipblas to confirm the image ID:

[
    {
        "Id": "sha256:7c9ffb9f8d249df6d068308adc9e8c1e5b183845031d6ff976b811ffe9106dee",
        "RepoTags": [
            "localai/localai:master-hipblas"
        ],
        "RepoDigests": [
            "localai/localai@sha256:a5dac979e4cac52729619c98daec793537d16c9ecc430d07c1a04cd6628973b7"
        ],
        "Parent": "",
        "Comment": "buildkit.dockerfile.v0",
        "Created": "2024-11-17T14:46:58.000365484Z",
        ...

...exit code 132 (Invalid OpCode).

I think it didn't contained the fix yet, but it should now - due to #4201. CI was failing before publishing all the images.

To double check you can compare the versions when running LocalAI: if you hit the /version endpoint or the webUI (at the bottom bar) it will show the commit version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants