[docs] Fix DatePicker of 'Customization' section #1904
Conversation
The DatePicker of 'Customization' section is broken. https://next.material-ui-pickers.dev/demo/datepicker#customization
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/agt3i6azj |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| const renderWeekPickerDay = (date, selectedDates, DayComponentProps) => { | ||
| let dateClone = makeJSDateObject(date); | ||
| let selectedDateClone = makeJSDateObject(selectedDate); | ||
| let selectedDateClone = makeJSDateObject(selectedDates[0]); |
There was a problem hiding this comment.
🤦♂️ it is fail
You are right, we changed calendar selected days to be an array when implementing date range picker. Here will be enough to only rename argument (because we have selected date available as state variable)
But this makes me think that we don't need this argument at all
|
Interesting. @dmtrKovalenko What do you think of updating the current eslint configuration to match the one from the main repository? If we lint
Arguably, it could help avoid cases like this one :) |
3 participants
Environment
Description
The DatePicker of 'Customization' section is broken.
https://next.material-ui-pickers.dev/demo/datepicker#customization