[test] Add conformance suite #14958
Merged
[test] Add conformance suite #14958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing f8e9c71...4836f6e |
eps1lon
force-pushed
the
test/conformance-suite
branch
from
72bf187 to
cde4efc
Compare
|
Did forget to push some local changes. Fails are fixed locally. |
eps1lon
force-pushed
the
test/conformance-suite
branch
2 times, most recently
from
8d27782 to
8dd30d4
Compare
oliviertassinari
approved these changes
Mar 20, 2019
eps1lon
force-pushed
the
test/conformance-suite
branch
from
a4b65bb to
7d484da
Compare
|
I overhauled the implementation of
The plan for this PR is to apply it to every component test where no changes to the implementation are needed. Some components don't quite work like the rest. For those components I will file separate PRs to discuss the implications. |
oliviertassinari
approved these changes
Mar 22, 2019
eps1lon
force-pushed
the
test/conformance-suite
branch
2 times, most recently
from
67feb13 to
d243de7
Compare
This was referenced Mar 23, 2019
eps1lon
force-pushed
the
test/conformance-suite
branch
3 times, most recently
from
114939d to
82b23ae
Compare
Tests that a component implements a common interface across all material-ui components.
eps1lon
force-pushed
the
test/conformance-suite
branch
from
82b23ae to
bd6253e
Compare
eps1lon
commented
Mar 26, 2019
oliviertassinari
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by semantic-ui test suite adds a common test for all core/ components.
We test these things sometimes in each component, sometimes we simply skip it. The approach is also pretty fragmented resulting in many forks of the same approach. This consolidates these test into a single description of a common API for
@material-ui/corecomponents.The endgame is to generate the docs from this descriptor instead of relying on code annotations like
@inheritComponent. Following the philosophy that tests are a form of documentation.Summary
Changes: +1,364 −1,110
Applied to the following core components:
Apply to all components that are conform
[ ] Boxunstable classnames[ ] TouchRippleneed imperative handle[ ] ClickAwayListenerexotic[ ] CssBaselineexotic[ ] Hiddenexotic[ ] ListItemAvatar(conditionalroot)[ ] NoSsrexotic[ ] Portalexotic[ ] RootRefexotic[ ] StepIconexotic