Skip to content

[core] Forward ref in Collapse, Popper and SwipeableDrawer #15170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 3, 2019
Merged

[core] Forward ref in Collapse, Popper and SwipeableDrawer #15170

merged 5 commits into from
Apr 3, 2019

Conversation

@eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 2, 2019 •
edited
Loading

Closes #10825 (finally)
Completes one task ("forward refs for every component") in #14415

@eps1lon eps1lon added type: new feature Expand the scope of the product to solve a new problem. component: Collapse The React component. component: Popper The React component. See <Popup> for the latest version. component: SwipeableDrawer The React component. labels Apr 2, 2019
@eps1lon eps1lon added this to the v4 milestone Apr 2, 2019
@eps1lon eps1lon force-pushed the feat/core/forward-ref branch from 836f244 to c332384 Compare April 3, 2019 01:12
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 3, 2019 •
edited
Loading

@material-ui/core: parsed: +0.07% , gzip: +0.20%

Details of bundle changes.

Comparing: 7c7645e...2905866

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.07% 🔺 +0.20% 🔺 349,285 349,535 89,690 89,873
@material-ui/core/Paper 0.00% -0.06% 67,853 67,853 19,820 19,809
@material-ui/core/Paper.esm 0.00% -0.03% 60,184 60,184 18,563 18,558
@material-ui/core/Popper +14.32% 🔺 +12.84% 🔺 30,463 34,825 10,531 11,883
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 17,364 17,364 5,726 5,726
@material-ui/core/useMediaQuery 0.00% +0.10% 🔺 2,469 2,469 1,041 1,042
@material-ui/lab +0.10% 🔺 +0.08% 🔺 147,195 147,341 43,520 43,556
@material-ui/styles 0.00% -0.03% 53,105 53,105 15,429 15,424
@material-ui/system 0.00% -0.07% 17,136 17,136 4,528 4,525
Button 0.00% -0.00% 87,928 87,929 26,057 26,056
Modal 0.00% 0.00% 82,035 82,035 24,553 24,553
colorManipulator 0.00% +0.15% 🔺 3,232 3,232 1,299 1,301
docs.landing 0.00% 0.00% 49,914 49,914 10,815 10,815
docs.main +0.04% 🔺 +0.06% 🔺 644,984 645,261 200,301 200,422
packages/material-ui/build/umd/material-ui.production.min.js +0.06% 🔺 +0.11% 🔺 297,774 297,953 82,568 82,660

Generated by 🚫 dangerJS against 2905866

@eps1lon eps1lon force-pushed the feat/core/forward-ref branch from c332384 to 3c05000 Compare April 3, 2019 09:30
@eps1lon eps1lon force-pushed the feat/core/forward-ref branch from 3c05000 to 2905866 Compare April 3, 2019 10:33
@eps1lon eps1lon marked this pull request as ready for review April 3, 2019 11:28
@eps1lon eps1lon mentioned this pull request Apr 3, 2019
Merged
@eps1lon eps1lon merged commit ae24eea into mui:next Apr 3, 2019
@eps1lon eps1lon deleted the feat/core/forward-ref branch April 3, 2019 12:18
@oliviertassinari oliviertassinari added the scope: drawer Changes related to the drawer. label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

component: Collapse The React component. component: Popper The React component. See <Popup> for the latest version. component: SwipeableDrawer The React component. scope: drawer Changes related to the drawer. type: new feature Expand the scope of the product to solve a new problem.

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@eps1lon @mui-pr-bot @oliviertassinari