Skip to content

[Collapse] Convert to function component #15248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 10, 2019
Merged

[Collapse] Convert to function component #15248

merged 11 commits into from
Apr 10, 2019

Conversation

@joshwooding
Copy link
Collaborator

@joshwooding joshwooding commented Apr 7, 2019

@joshwooding joshwooding added type: new feature Expand the scope of the product to solve a new problem. component: Collapse The React component. labels Apr 7, 2019
@joshwooding joshwooding mentioned this pull request Apr 7, 2019
Closed
29 tasks
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 7, 2019 •
edited
Loading

@material-ui/core: parsed: -0.26% 😍, gzip: -0.17% 😍

Details of bundle changes.

Comparing: 1fa8f94...a7593db

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.26% -0.17% 347,568 346,671 89,893 89,740
@material-ui/core/Paper 0.00% 0.00% 68,404 68,404 20,053 20,053
@material-ui/core/Paper.esm 0.00% 0.00% 60,735 60,735 18,785 18,785
@material-ui/core/Popper 0.00% 0.00% 34,930 34,930 11,917 11,917
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 17,877 17,877 5,962 5,962
@material-ui/core/useMediaQuery 0.00% 0.00% 2,463 2,463 1,044 1,044
@material-ui/lab 0.00% 0.00% 148,119 148,119 43,913 43,913
@material-ui/styles 0.00% 0.00% 53,143 53,143 15,443 15,443
@material-ui/system 0.00% 0.00% 17,132 17,132 4,519 4,519
Button 0.00% 0.00% 88,669 88,669 26,423 26,423
Modal 0.00% 0.00% 82,688 82,688 24,802 24,802
colorManipulator 0.00% 0.00% 3,745 3,745 1,537 1,537
docs.landing 0.00% 0.00% 49,820 49,820 10,807 10,807
docs.main -0.14% -0.29% 644,630 643,709 200,877 200,287
packages/material-ui/build/umd/material-ui.production.min.js -0.27% -0.14% 296,257 295,459 82,811 82,698

Generated by 🚫 dangerJS against a7593db

@joshwooding joshwooding force-pushed the collapse-function-component branch 2 times, most recently from 5956a98 to 5729ef8 Compare April 7, 2019 21:49
oliviertassinari
oliviertassinari reviewed Apr 8, 2019
View reviewed changes
joshwooding
joshwooding commented Apr 8, 2019
View reviewed changes
oliviertassinari
oliviertassinari reviewed Apr 9, 2019
View reviewed changes
@joshwooding joshwooding force-pushed the collapse-function-component branch from 18dd4cd to 2d61554 Compare April 9, 2019 21:34
eps1lon
eps1lon reviewed Apr 10, 2019
View reviewed changes
@eps1lon @joshwooding
Missing brackets
a7593db 
Co-Authored-By: joshwooding <[email protected]>
@oliviertassinari oliviertassinari merged commit dcb334e into mui:next Apr 10, 2019
@joshwooding joshwooding deleted the collapse-function-component branch April 10, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon left review comments

Assignees

No one assigned

Labels

component: Collapse The React component. type: new feature Expand the scope of the product to solve a new problem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joshwooding @mui-pr-bot @oliviertassinari @eps1lon