Skip to content

[material-ui][MobileStepper] Convert to support CSS extraction #41533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 20, 2024
Merged

[material-ui][MobileStepper] Convert to support CSS extraction #41533

merged 12 commits into from
Mar 20, 2024

Conversation

@aacevski
Copy link
Contributor

@aacevski aacevski commented Mar 17, 2024 •
edited
Loading

I have only interacted with the MobileStepper components since that was the code I have changed.

@siriwatknp for some reason the sx props passed on the documentation isn't going to the MobileStepperRoot, do you have any idea on why this might happen?

image
Screen.Recording.2024-03-18.at.19.43.46.mov

@aacevski aacevski marked this pull request as draft March 17, 2024 21:41
@aacevski aacevski marked this pull request as ready for review March 17, 2024 22:46
siriwatknp
siriwatknp reviewed Mar 18, 2024
View reviewed changes
@siriwatknp
Copy link
Member

siriwatknp commented Mar 18, 2024

@siriwatknp for some reason the sx props passed on the documentation isn't going to the MobileStepperRoot, do you have any idea on why this might happen?

That's expected. The sx is out of the scope of the migration. @brijeshb42 is working on it.

@siriwatknp siriwatknp added on hold There is a blocker, we need to wait. scope: stepper Changes related to the stepper. package: material-ui v6.x labels Mar 18, 2024
brijeshb42
brijeshb42 reviewed Mar 18, 2024
View reviewed changes
@aacevski aacevski requested a review from brijeshb42 March 18, 2024 18:46
@aacevski
Copy link
Contributor Author

aacevski commented Mar 18, 2024

Thank you for your feedback! 🙌🏼 I have resolved all the comments and updated the video.

@aacevski aacevski requested a review from siriwatknp March 18, 2024 18:47
@siriwatknp siriwatknp mentioned this pull request Mar 19, 2024
Closed
62 tasks
@mnajdova mnajdova changed the base branch from master to next March 19, 2024 09:31
siriwatknp
siriwatknp approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mui-bot
Copy link

mui-bot commented Mar 20, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41533--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against c87d7d5

@siriwatknp siriwatknp removed the on hold There is a blocker, we need to wait. label Mar 20, 2024
@siriwatknp siriwatknp merged commit 01e3310 into mui:next Mar 20, 2024
pluvio72 pushed a commit to pluvio72/material-ui that referenced this pull request Mar 29, 2024
@aacevski @pluvio72
[material-ui][MobileStepper] Convert to support CSS extraction (mui#4…
4d67bc5 
…1533)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@brijeshb42 brijeshb42 Awaiting requested review from brijeshb42

Assignees

No one assigned

Labels

scope: stepper Changes related to the stepper. v6.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aacevski @siriwatknp @mui-bot @brijeshb42