Added null checks to dynamic store APIs
#59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
approved these changes
Sep 18, 2025
dlon
force-pushed
the
dynamicstore_null_checks
branch
from
84cd925 to
b0c5883
Compare
dlon
force-pushed
the
dynamicstore_null_checks
branch
from
b0c5883 to
d525d2a
Compare
Member
|
Thank you and sorry about the incredibly late response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed crashes due to missing
nullchecks indynamic_store.rs.Additional background:
SCDynamicStoreCreate/SCDynamicStoreCreateWithOptionscan returnnull. The returned value is currently passed towrap_under_create_rulewithout anullcheck, which leads to an assertion error (Attempted to create a NULL object).This PR adds additional checks and modifies affected APIs to return an
Optioninstead.This change is