Fix #4029: Expire vector display instances after SVG destruction #4041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This will be merged shortly, first we'll just get a nightly build that only includes the LunaSVG vendor update (#4067), in case we need to distinguish testing results for any reason. |
TheNormalnij
reviewed
Mar 6, 2025
TheNormalnij
reviewed
Mar 6, 2025
|
|
||
| void CClientVectorGraphic::OnUpdate() | ||
| { | ||
| if (!m_pVectorGraphicDisplay) |
Member
There was a problem hiding this comment.
Is this situation possible?
Member
|
How does your fix work? |
Member
Author
|
See #4108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4029 by using the functionality in
CClientDisplayManager::DoPulsewhich cleans up expired elements.After the underlying vector graphic has been destroyed, an expiration of 1ms is set on the vector display instance so the manager can clean it up automatically.
Display instances are already destroyed/cleared upon destruction of the display manager.
Tested lightly by creating multiple SVGs, modifying them (updating, destroying) and manually tracking the lifetime of display instances in debugger. Seems to work as intended through restarting resources, disconnecting & exiting the client.