Fix crash when requesting CJ clothing model #4419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the condition for initializing blockOffsetToFileIdMap and blockOffsetToFileNameMap to also trigger when ms_ClothesFileDataMap is not empty, ensuring proper map setup when clothes data is present.
Contributor
|
Ok so this might be what I was experiencing while testing (mouse became extremely laggy after allocating, game froze and crashed without dump), right? |
botder
approved these changes
Sep 5, 2025
Contributor
|
Just a note of appreciation: it's really cool to finally see the CJ skin changing body and clothing models... a much awaited feature 😜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when requesting a clothing model, the game would crash due to an infinite loop. This PR solves this problem. The system was functioning normally, but this error could eventually occur. After receiving reports, I reviewed the code and noticed an incorrect use of static that had gone unnoticed.
I recorded a short video demonstrating a system I made using this new feature. Watch the video below:
Grand.Theft.Auto.San.Andreas.2025.09.04.-.11.46.47.07.mp4