Skip to content

Fix missing mtaserver.conf setting added from template not receiving attributes #4452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2025
Merged

Fix missing mtaserver.conf setting added from template not receiving attributes #4452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Server/mods/deathmatch/logic/CMainConfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,7 @@ bool CMainConfig::AddMissingSettings()
CXMLAttribute* templateAttribute = *it3;
const SString& attrName = templateAttribute->GetName();

// Don't check value attribute which is intended to be different
// Don't check value attribute which is intended to be customized by the server
if (attrName == "value")
continue;

Expand Down Expand Up @@ -946,6 +946,12 @@ bool CMainConfig::AddMissingSettings()
foundNode->SetTagContent(templateNodeValue.c_str());
foundNode->SetCommentText(templateNodeComment.c_str(), true);

for (auto it3 = templateAttributes.ListBegin(); it3 != templateAttributes.ListEnd(); ++it3)
{
CXMLAttribute* templateAttribute = *it3;
foundNode->GetAttributes().Create(*templateAttribute);
}

CLogger::LogPrintf("Added missing '%s' setting to mtaserver.conf\n", templateNodeName.c_str());
configChanged = true;
}
Expand Down