Skip to content

Conversation

tederis
Copy link
Member

@tederis tederis commented Oct 4, 2025

m_pCurrentLang pointer is uninitialized currently which is UB and causes random crashes during a startup process. This PR fixes it.

@Dutchman101 Dutchman101 merged commit 96cf6e3 into multitheftauto:master Oct 4, 2025
6 of 7 checks passed
MTABot pushed a commit that referenced this pull request Oct 4, 2025
@Fernando-A-Rocha
Copy link
Contributor

Did someone experience the random crashes before?

@tederis
Copy link
Member Author

tederis commented Oct 4, 2025

Did someone experience the random crashes before?

I personally have experienced it today for the first time. And it's quite strange that it had never happened before. Though... I had encountered weird crashes on game start some time ago, but didn't explore it further.

@tederis tederis deleted the fixes/lang_crashfix branch October 4, 2025 12:04
Dutchman101 pushed a commit that referenced this pull request Oct 5, 2025
MTABot pushed a commit that referenced this pull request Oct 5, 2025
2daba7b Update DX SDK requirement
8058af5 Addendum #1 to ca5ca19
e0933ad Rewrite Crash handler (to more reliably catch, dialog, dump and process all types of exceptions, even stack buffer overruns) Aims to reduce "MTA closed without anything", the handler was on ancient code and badly needed modernization away from deprecated API's as well.
bc6e7c0 Fix GUI related crashes and regressions/bad code
b596e87 Crashfix (uninitialized ptr) (#4508)
251b8ac Addendum #2 to 86ad47c & dc0fb96
2425c4c Addendum to last
37784c8 Replace ReadRegistryStringValue
b162368 Addendum to 86ad47c & dc0fb96
a2d20ba GUI related safety tweaks
bfd1306 Fix memory leak in main menu (News browser)
ea949b2 Further improve settings window scaling on low res
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants