Skip to content

Feature/limit permissions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Feature/limit permissions #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e45a2f
Adding updates to limit permission requests when making changes
nkeating-mutualofenumclaw Sep 22, 2020
c772832
Updating readme with pointer to security masking
nkeating-mutualofenumclaw Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,10 @@ This function will close the open connection if opened, it will be called automa
Copyright (C) 2014 Microsoft
http://msdn.microsoft.com/en-us/library/cc246482.aspx

### Permissions References
2.2.13.1.2 Directory_Access_Mask
https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-smb2/0a5934b1-80f1-4da0-b1bf-5e021c309b71

## License

(The MIT License)
Expand Down
2 changes: 1 addition & 1 deletion lib/api/exists.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ module.exports = function(path, cb){

var connection = this;

SMB2Request('open', {path:path}, connection, function(err, file){
SMB2Request('open', {path:path, access: 0x80000000 }, connection, function(err, file){
if(err) cb && cb(null, false);
else SMB2Request('close', file, connection, function(err){
cb && cb(null, true);
Expand Down
2 changes: 1 addition & 1 deletion lib/api/mkdir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ module.exports = function(path, mode, cb){
else if(!exists){

// SMB2 open file
SMB2Request('create_folder', {path:path}, connection, function(err, file){
SMB2Request('create_folder', {path:path, access: 0x40000000}, connection, function(err, file){
if(err) cb && cb(err);
// SMB2 query directory
else SMB2Request('close', file, connection, function(err){
Expand Down
2 changes: 1 addition & 1 deletion lib/api/readfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ module.exports = function(filename, options, cb){
options = {};
}

SMB2Request('open', {path:filename}, connection, function(err, file){
SMB2Request('open', {path:filename, access: 0x80000000}, connection, function(err, file){
if(err) cb && cb(err);
// SMB2 read file content
else {
Expand Down
2 changes: 1 addition & 1 deletion lib/api/rename.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module.exports = function(oldPath, newPath, cb){

// SMB2 open the folder / file
SMB2Request('open_folder', {path:oldPath}, connection, function(err, file){
if(err) SMB2Request('open', {path:oldPath}, connection, function(err, file){
if(err) SMB2Request('open', {path:oldPath, access: 0x40000000 }, connection, function(err, file){
if(err) cb && cb(err);
else rename(connection, file, newPath, cb);
});
Expand Down
2 changes: 1 addition & 1 deletion lib/api/unlink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ module.exports = function(path, cb){
else if(exists){

// SMB2 open file
SMB2Request('create', {path:path}, connection, function(err, file){
SMB2Request('create', {path:path, access: 0x40000000}, connection, function(err, file){
if(err) cb && cb(err);
// SMB2 query directory
else SMB2Request('set_info', {FileId:file.FileId, FileInfoClass:'FileDispositionInformation',Buffer:(new bigint(1,1)).toBuffer()}, connection, function(err, files){
Expand Down
2 changes: 1 addition & 1 deletion lib/api/writefile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ module.exports = function(filename, data, options, cb){
;

function createFile(fileCreated){
SMB2Request('create', {path:filename}, connection, function(err, f){
SMB2Request('create', {path:filename, access: 0x40000000 }, connection, function(err, f){
if(err) cb && cb(err);
// SMB2 set file size
else {
Expand Down
2 changes: 1 addition & 1 deletion lib/messages/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ module.exports = message({
}
, request:{
'Buffer':buffer
, 'DesiredAccess':0x001701DF
, 'DesiredAccess': params.access == undefined? 0x001701DF : params.access
, 'FileAttributes':0x00000080
, 'ShareAccess':0x00000000
, 'CreateDisposition':0x00000005
Expand Down
2 changes: 1 addition & 1 deletion lib/messages/create_folder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ module.exports = message({
}
, request:{
'Buffer':buffer
, 'DesiredAccess':0x001701DF
, 'DesiredAccess': params.access == undefined? 0x001701DF : params.access
, 'FileAttributes':0x00000000
, 'ShareAccess':0x00000000
, 'CreateDisposition':0x00000002
Expand Down
2 changes: 1 addition & 1 deletion lib/messages/open.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ module.exports = message({
}
, request:{
'Buffer':buffer
, 'DesiredAccess':0x001701DF
, 'DesiredAccess': params.access == undefined? 0x001701DF : params.access
, 'NameOffset':0x0078
, 'CreateContextsOffset':0x007A+buffer.length
}
Expand Down