Tests of mem issue. #101
Merged
Tests of mem issue. #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Worker actor loops over a file, it does not always deallocate file chunks until the loop completes. Because each ChunkWorker is intended to be only used once, it is not necessary to keep a reference to its file chunk beyond the upload task call.
andrewjl-mux
force-pushed
the
mem_issue
branch
2 times, most recently
from
130fd9a to
d4df788
Compare
andrewjl-mux
approved these changes
Mar 15, 2024
Merged
andrewjl-mux
added a commit
that referenced
this pull request
Mar 15, 2024
* feature: add macos deployment target (#102) * fix: clean up chunk memory (#101) * avoid keeping a reference to the file chunk in ChunkWorker When the Worker actor loops over a file, it does not always deallocate file chunks until the loop completes. Because each ChunkWorker is intended to be only used once, it is not necessary to keep a reference to its file chunk beyond the upload task call. --------- Co-authored-by: AJ Lauer Barinov <[email protected]> --------- Co-authored-by: Eden Halperin <[email protected]> Co-authored-by: Tomislav Kordic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory tests.