Remove stored file size property from ChunkedFile #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjl-mux
commented
Jul 6, 2023
andrewjl-mux
commented
Jul 6, 2023
daytime-em
requested changes
Jul 6, 2023
Collaborator
daytime-em
left a comment
daytime-em
left a comment
There was a problem hiding this comment.
I really love this idea! Maybe the rest of the code that relies on fileSize could also benefit from this approach
cjpillsbury
reviewed
Jul 6, 2023
Contributor
cjpillsbury
left a comment
cjpillsbury
left a comment
There was a problem hiding this comment.
Added some thoughts.
andrewjl-mux
force-pushed
the
ajlb/file-size
branch
from
0f668dd to
a66d667
Compare
daytime-em
reviewed
Jul 6, 2023
andrewjl-mux
changed the title
Contributor
Author
|
Updated PR title and description so its more apparent what's changing vs not changing |
Store fileURL inside ChunkedFile when an active handle is available Simplify state checking inside ChunkedFile Prevent potential crash due to overflow Remove SIZE_UNKNOWN Keep a reference to FileManager for eventual dependency injection when initializing ChunkedFile
andrewjl-mux
force-pushed
the
ajlb/file-size
branch
from
79d8f57 to
58042a1
Compare
daytime-em
approved these changes
Jul 6, 2023
Collaborator
daytime-em
left a comment
daytime-em
left a comment
There was a problem hiding this comment.
LGTM I just had a question about swift practices
# Conflicts: # Sources/MuxUploadSDK/Upload/ChunkedFileUploader.swift
daytime-em
approved these changes
Jul 6, 2023
Collaborator
daytime-em
left a comment
daytime-em
left a comment
There was a problem hiding this comment.
Thanks for the discussion!
andrewjl-mux
force-pushed
the
ajlb/file-size
branch
from
f695635 to
1cd7591
Compare
Contributor
Author
|
Just force pushed because the new file wasn't picked up earlier, merging now. |
andrewjl-mux
added a commit
that referenced
this pull request
Jul 19, 2023
Store fileURL inside ChunkedFile when an active handle is available Simplify state checking inside ChunkedFile Prevent potential crash due to overflow Remove SIZE_UNKNOWN Keep a reference to FileManager for eventual dependency injection when initializing ChunkedFile Add extension method to work around Swift compiler buffoonery
cjpillsbury
pushed a commit
that referenced
this pull request
Jul 20, 2023
Store fileURL inside ChunkedFile when an active handle is available Simplify state checking inside ChunkedFile Prevent potential crash due to overflow Remove SIZE_UNKNOWN Keep a reference to FileManager for eventual dependency injection when initializing ChunkedFile Add extension method to work around Swift compiler buffoonery
andrewjl-mux
added a commit
that referenced
this pull request
Jul 20, 2023
Store fileURL inside ChunkedFile when an active handle is available Simplify state checking inside ChunkedFile Prevent potential crash due to overflow Remove SIZE_UNKNOWN Keep a reference to FileManager for eventual dependency injection when initializing ChunkedFile Add extension method to work around Swift compiler buffoonery
Merged
andrewjl-mux
added a commit
that referenced
this pull request
Jul 20, 2023
Store fileURL inside ChunkedFile when an active handle is available Simplify state checking inside ChunkedFile Prevent potential crash due to overflow Remove SIZE_UNKNOWN Keep a reference to FileManager for eventual dependency injection when initializing ChunkedFile Add extension method to work around Swift compiler buffoonery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the file size is stored in ChunkedFile, this happens as a side effect of opening the file. This PR removes the stored property and retrieves the file size from
FileManagerdirectly whenever it is needed. The intention of this change is to reduced duplicate state between the SDK andFileManageras well as reduce the number of possible state permutations the SDK can take on.