Skip to content

Conversation

@marcusirgens
Copy link
Contributor

This issue tracks a more thorough rewrite of this code, which has turned a bit stale. This includes the fixes in #51, which replaces the framing logic with the more idiomatic anypb.Any type, while also removing the deprecated grpc.CustomCodec() calls.

As far as I can tell, this rewrite is 100% backwards compatible, but I'm eager to perform some more tests with some more complex protos.

This PR includes

  • Some more tests of the testing server
  • A more flexible testing server
  • Rewrite to go modules
  • Some sugar methods and sane defaults for ease of use (proxy.NewProxy)

I do suggest tagging this as 0.2 if this is merged at some point.

Feedback and contributions are greatly appreciated.

@marcusirgens marcusirgens marked this pull request as ready for review April 2, 2021 00:52
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DennisMao
Copy link

.editconfig can be reomved or igored.

@johanbrandhorst
Copy link
Collaborator

(I don't have the permission to merge this).

@tmc
Copy link

tmc commented Jan 1, 2022

@mwitkow would you be open to opening up maintainers on this codebase?

@bwplotka bwplotka merged commit db34e7b into mwitkow:master Jan 26, 2022
@bwplotka
Copy link
Collaborator

Thanks @johanbrandhorst and others! Let's get this rolling 💪🏽

@tmc I think we should add more maintainers and I can try to arrange that (I can't add people), if anyone wants to help. Feel free to shoot me a message to bwplotka @ gmail.com

@johanbrandhorst do you have time to help too? 🙈

@bwplotka
Copy link
Collaborator

Great work BTW @marcusirgens - this was definitely needed.

@johanbrandhorst
Copy link
Collaborator

I would love to help if I can :)

@marcusirgens
Copy link
Contributor Author

I'm open to contributing to this project. 👍🏻

@fabregas
Copy link

fabregas commented Apr 7, 2022

@marcusirgens you can't unmarshal any binary protobuf message to anypb.Any. This is wrong assumption.

Any message declaration:

message Any {
string type_url = 1;
bytes value = 2;
}

So in some cases we will receive error "grpc: failed to unmarshal the received message string field contains invalid UTF-8" bcs it can't unmarshal type_url string.

ymcvalu added a commit to ymcvalu/grpc-proxy that referenced this pull request Sep 25, 2022
Remove deprecated logic, modernise project (mwitkow#52)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants