-
Notifications
You must be signed in to change notification settings - Fork 225
Remove deprecated logic, modernise project #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
.editconfig can be reomved or igored. |
|
(I don't have the permission to merge this). |
|
@mwitkow would you be open to opening up maintainers on this codebase? |
|
Thanks @johanbrandhorst and others! Let's get this rolling 💪🏽 @tmc I think we should add more maintainers and I can try to arrange that (I can't add people), if anyone wants to help. Feel free to shoot me a message to bwplotka @ gmail.com @johanbrandhorst do you have time to help too? 🙈 |
|
Great work BTW @marcusirgens - this was definitely needed. |
|
I would love to help if I can :) |
|
I'm open to contributing to this project. 👍🏻 |
|
@marcusirgens you can't unmarshal any binary protobuf message to anypb.Any. This is wrong assumption. Any message declaration: message Any { So in some cases we will receive error "grpc: failed to unmarshal the received message string field contains invalid UTF-8" bcs it can't unmarshal type_url string. |
Remove deprecated logic, modernise project (mwitkow#52)
This issue tracks a more thorough rewrite of this code, which has turned a bit stale. This includes the fixes in #51, which replaces the framing logic with the more idiomatic
anypb.Anytype, while also removing the deprecatedgrpc.CustomCodec()calls.As far as I can tell, this rewrite is 100% backwards compatible, but I'm eager to perform some more tests with some more complex protos.
This PR includes
proxy.NewProxy)I do suggest tagging this as 0.2 if this is merged at some point.
Feedback and contributions are greatly appreciated.