Add batch command API #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bradley Grainger <[email protected]>
bgrainger
force-pushed
the
batch-commands
branch
from
fb1a4a5 to
532ec42
Compare
Introduced IMySqlCommand abstraction for commands and batch commands. Replaced PreparedStatementCommandExecutor with ICommandPayloadCreator and a new mechanism for executing commands in a loop. MySqlDataReader can iterate over multiple commands and return multiple result sets. Many features for batched commands are not yet implemented but the basic framework is now in place and can be extended. Signed-off-by: Bradley Grainger <[email protected]>
Conventionally, most types in MySqlConnector do not include "Db" in their name. Signed-off-by: Bradley Grainger <[email protected]>
The batch execution infrastructure permits a single MySqlDataReader to loop over multiple separate commands. Signed-off-by: Bradley Grainger <[email protected]>
These are currently too flaky for CI builds. Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
These are now executed through the new batch execution pipeline. Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
bgrainger
force-pushed
the
batch-commands
branch
from
12fdd61 to
4824adf
Compare
The only CommandBehavior value that is currently handled is CommandBehavior.CloseConnection, which isn't valid inside a batch. Signed-off-by: Bradley Grainger <[email protected]>
Signed-off-by: Bradley Grainger <[email protected]>
bgrainger
force-pushed
the
batch-commands
branch
from
2c23e55 to
636f3d5
Compare
Prepared batch commands will be implemented later. Signed-off-by: Bradley Grainger <[email protected]>
|
👍 Looking forward to hearing results :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the API from https://github.com/dotnet/corefx/issues/35135.
Further work is tracked by #655 and #656.