-
Notifications
You must be signed in to change notification settings - Fork 306
docs: fix docs.rs docs generation #3514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- fix some links - replace doc_auto_cfg with doc_cfg as instructed by the failed docs.rs run [INFO] [stderr] 253 | #![cfg_attr(iroh_docsrs, feature(doc_auto_cfg))] [INFO] [stderr] | ^^^^^^^^^^^^ feature has been removed [INFO] [stderr] | [INFO] [stderr] = note: removed in CURRENT_RUSTC_VERSION; see <rust-lang/rust#138907> for more information [INFO] [stderr] = note: merged into `doc_cfg`
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3514/docs/iroh/ Last updated: 2025-10-09T10:00:32Z |
|
Maybe let's update all nightly toolchain uses in one go? |
Yeah, you are right. Missed the one in docs.yaml. For the ones in tests.yaml there is nothing to do since they don't mention explicit versions, right? |
|
Did a quick check. Main does indeed fail with latest nightly: #![cfg_attr(iroh_docsrs, feature(doc_auto_cfg))] |
|
@ramfox we should do a patch release with just this, to make sure docs.rs is fixed |
Description
Try to fix docs.rs docs generation
[INFO] [stderr] 253 | #![cfg_attr(iroh_docsrs, feature(doc_auto_cfg))]
[INFO] [stderr] | ^^^^^^^^^^^^ feature has been removed
[INFO] [stderr] |
[INFO] [stderr] = note: removed in CURRENT_RUSTC_VERSION; see rust-lang/rust#138907 for more information
[INFO] [stderr] = note: merged into
doc_cfgBreaking Changes
None
Notes & open questions
Not sure how to test this.
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme