Skip to content

Conversation

hildjj
Copy link
Contributor

@hildjj hildjj commented Aug 17, 2025

Except left eslint at 8.57 since moving to eslint
9 requires maintainer decisions. Added @types/node to get tests to pass. Refreshed package-lock.json to ensure that "npm audit" is clean.

Pre-requisite to fixing #207

Except left eslint at 8.57 since moving to eslint
9 requires maintainer decisions.  Added @types/node
to get tests to pass.  Refreshed package-lock.json
to ensure that "npm audit" is clean.
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 17, 2025
@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@dosubot dosubot bot added the dependencies Pull requests that update a dependency file label Aug 17, 2025
@hildjj hildjj changed the title chore(deps): updated all dependencies chore(deps): updated all dependencies (pre-req for #207) Aug 17, 2025
@hildjj
Copy link
Contributor Author

hildjj commented Aug 17, 2025

I don't know what the bot wants me to change. Please feel free to edit the descriptions as necessary.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 18, 2025
@simoneb
Copy link
Member

simoneb commented Aug 18, 2025

CI is failing. Note that we usually prefer relying on dependabot for the dependency bumps.

@hildjj
Copy link
Contributor Author

hildjj commented Aug 18, 2025

Let's see if this works; npm ci runs clean on my machine now.

@hildjj
Copy link
Contributor Author

hildjj commented Aug 18, 2025

Also, I'm happy to let this PR go, and rebase #209 wherever you like.

@simoneb
Copy link
Member

simoneb commented Aug 19, 2025

CI is still failing

@simoneb
Copy link
Member

simoneb commented Aug 19, 2025

@hildjj one Q: why is this a prerequisite for #209 ?

@hildjj
Copy link
Contributor Author

hildjj commented Aug 20, 2025

CI fails on the master branch also for node 24.6, but not for node 24.5 with the same error. I'm looking into why.

@hildjj
Copy link
Contributor Author

hildjj commented Aug 20, 2025

This CI error is caused by nodejs/node#58253 which changed Assert to become a class.

  • I'm going to close this PR as it's clear you want to manage dependencies otherwise.
  • I'll start a new PR where we can discuss the fix for this (my approach is going to be to add another sed to compare.sh, to ensure the tests work on all supported versions of node).
  • I'll rebase fix #207: assign diagnostic to correct test #209 on top of master, with no changes to dependencies.

@hildjj hildjj closed this Aug 20, 2025
@hildjj hildjj deleted the update-dependencies branch August 20, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants