Skip to content

[Snyk] Upgrade redis from 4.0.2 to 4.7.1 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Upgrade redis from 4.0.2 to 4.7.1 #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
243 changes: 116 additions & 127 deletions Socket IO Chat App/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Socket IO Chat App/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"dotenv": "^14.3.2",
"express": "^4.18.2",
"moment": "^2.29.4",
"redis": "^4.0.2",
"redis": "^4.7.1",
Copy link

@gemini-code-assist gemini-code-assist bot Jun 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With the redis package now at ^4.7.1, one of its key dependencies (@redis/client) requires Node.js >=14.

To improve project maintainability and prevent potential runtime issues, would it be beneficial to add an engines field to this package.json? This would explicitly declare the Node.js version(s) this project supports and is tested against. For example:

{
  // ... other package.json fields
  "engines": {
    "node": ">=14.0.0"
  }
}

This would make the project's Node.js requirement clear and could be used by CI/CD systems to enforce compatibility.

"socket.io": "^4.6.1"
},
"devDependencies": {
Expand Down