-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade @testing-library/jest-dom from 5.12.0 to 5.17.0 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade @testing-library/jest-dom from 5.12.0 to 5.17.0. See this package in npm: @testing-library/jest-dom See this project in Snyk: https://app.snyk.io/org/newtonombese1/project/80832d9c-5c81-4b5c-bcfa-662889227677?utm_source=github&utm_medium=referral&page=upgrade-pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on maintaining the project's dependencies by updating a key testing library. The primary goal is to ensure the project benefits from the latest features, bug fixes, and security improvements provided by the updated package, thereby enhancing the overall stability and maintainability of the codebase.
Highlights
- Dependency Upgrade: This pull request, automatically generated by Snyk, upgrades the
@testing-library/jest-dompackage from version5.12.0to5.17.0. - New Feature and Deprecation: Version
5.17.0introduces a new matchertoHaveAccessibleErrorMessageand deprecates the oldertoHaveErrorMessage. - Maintenance and Security: The upgrade aims to keep dependencies up-to-date, facilitating easier fixes for existing vulnerabilities and quicker identification of new ones.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades @testing-library/jest-dom to version 5.17.0. This is a significant update that includes a potentially breaking change: the toHaveErrorMessage matcher has been deprecated and replaced with toHaveAccessibleErrorMessage. It is important to update any tests that use the deprecated matcher. I also recommend running the full test suite to ensure there are no regressions. Furthermore, this pull request should include the updated package-lock.json file to ensure that builds are reproducible across all environments.
| "private": true, | ||
| "dependencies": { | ||
| "@testing-library/jest-dom": "^5.11.4", | ||
| "@testing-library/jest-dom": "^5.17.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The toHaveErrorMessage matcher is deprecated in @testing-library/jest-dom v5.17.0 and has been replaced by toHaveAccessibleErrorMessage. You should update any tests using the old matcher to prevent future breakages and ensure your tests align with the library's latest API. Running the full test suite after this upgrade is also crucial to catch any potential regressions.
Snyk has created this PR to upgrade @testing-library/jest-dom from 5.12.0 to 5.17.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 12 versions ahead of your current version.
The recommended version was released 2 years ago.
Release notes
Package name: @testing-library/jest-dom
-
5.17.0 - 2023-07-18
- New
-
5.16.5 - 2022-08-04
- migrate ccs v3 to @ adobe/css-tools v4 (#470) (948d90f)
-
5.16.4 - 2022-04-05
- Support unenclosed inner text for details elements in to be visible (#396) (af18453)
-
5.16.3 - 2022-03-24
- clarify toHaveFocus message when using
-
5.16.2 - 2022-02-03
- add custom element support to
-
5.16.1 - 2021-12-06
- Improve
-
5.16.0 - 2021-12-03
- Update aria-query to 5.0.0 (#414) (de26c7a)
-
5.15.1 - 2021-11-23
- wrong deprecate error message (#422) (dfcefa2)
-
5.15.0 - 2021-11-02
- import parse directly from css (#415) (4cb606c)
-
5.14.1 - 2021-06-11
- Updates deprecated matchers info (#378) (fc9ce6d)
-
5.14.0 - 2021-06-11
-
5.13.0 - 2021-06-03
-
5.12.0 - 2021-04-22
from @testing-library/jest-dom GitHub release notes5.17.0 (2023-07-18)
Features
toHaveAccessibleErrorMessagebetter implementing the spec, deprecatetoHaveErrorMessage(#503) (d717c66)5.16.5 (2022-08-04)
Bug Fixes
5.16.4 (2022-04-05)
Bug Fixes
5.16.3 (2022-03-24)
Bug Fixes
.not(#447) (6988a67)5.16.2 (2022-02-03)
Bug Fixes
toBeDisabled(#368) (8162115)5.16.1 (2021-12-06)
Bug Fixes
toHaveClasserror message format (#405) (a9beb47)5.16.0 (2021-12-03)
Features
5.15.1 (2021-11-23)
Bug Fixes
5.15.0 (2021-11-02)
Features
5.14.1 (2021-06-11)
Bug Fixes
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: