Fix connection acquisition timeout #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the driver is performing routing, the connection acquisition for a connection to the router should also be affected by the connection acquisition timeout. However, it should have its own timeout because it's a separate acquisition.
bigmontz
approved these changes
Aug 3, 2022
| def test_router_handshake_has_own_timeout_in_time(self): | ||
| self._start_server(self._router, "router_hello_delay.script") | ||
| self._start_server(self._server, "session_run.script") | ||
| self._start_server(self._server, "session_run_auth_delay.script") |
There was a problem hiding this comment.
Why did you need to add delay to the session run?
There was a problem hiding this comment.
Because I want to make sure that the connection_acquisition_timeout_ms (6000ms) counts for each connection acquisition separately. So even though the total delay (4s during router handshake, 4s during reader handshake) exceeds the set timeout, it should still work because the individual delays are below the timeout.
fbiville
approved these changes
Aug 3, 2022
injectives
approved these changes
Aug 3, 2022
robsdedude
added a commit
to neo4j/neo4j-dotnet-driver
that referenced
this pull request
Aug 5, 2022
The driver was behaving correctly. The TestKit tests were adjusted: neo4j-drivers/testkit#504 Hence, the skip can be removed.
robsdedude
added a commit
to neo4j/neo4j-dotnet-driver
that referenced
this pull request
Aug 8, 2022
The driver was behaving correctly. The TestKit tests were adjusted: neo4j-drivers/testkit#504 Hence, the skip can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the driver is performing routing, the connection acquisition for a
connection to the router should also be affected by the connection acquisition
timeout. However, it should have its own timeout because it's a separate
acquisition.
Depends on: