Fix DateTime test #513
Merged
Fix DateTime test #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test started failing because 4.4 servers with the UTC patch started appearing. The test did not account for all implications of the new protocol specs.
fbiville
approved these changes
Sep 2, 2022
| return map(lambda x: getattr(x, "value", x), rec.values) | ||
|
|
||
| self._create_driver_and_session() | ||
| server_supports_utc = get_server_info().has_utc_patch |
There was a problem hiding this comment.
why is it not a simple boolean?
There was a problem hiding this comment.
ok, I found out why below.
maybe it could be renamed server_version_may_support_utc :P
There was a problem hiding this comment.
Yeah, for 4.4 and 4.3 there's no straight-forward way for TestKit to know if the server supports the UTC patch or not. So this value can be 1 yes, 0 no, and 0.5 maybe 😬
There was a problem hiding this comment.
might we consider an enum?
robsdedude
added a commit
that referenced
this pull request
Sep 2, 2022
robsdedude
added a commit
that referenced
this pull request
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test started failing because 4.4 servers with the UTC patch started appearing.
The test did not account for all implications of the new protocol specs.