Unsupported type stub tests #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
reviewed
Sep 4, 2025
injectives
reviewed
Sep 4, 2025
robsdedude
reviewed
Sep 8, 2025
robsdedude
reviewed
Sep 12, 2025
2 tasks
U comes before V in the alphabet.
robsdedude
reviewed
Sep 15, 2025
injectives
reviewed
Sep 18, 2025
injectives
reviewed
Sep 19, 2025
| # The driver supports sending and receiving temporal data types. | ||
| API_TYPE_TEMPORAL = "Feature:API:Type.Temporal" | ||
| # The driver supports sending and receiving the unsupported type data type. | ||
| API_TYPE_UNSUPPORTED_TYPE = "Feature:API:Type.UnsupportedType" |
There was a problem hiding this comment.
Isn't this part of Bolt 6.0? Maybe we don't need a feature flag for it.
There was a problem hiding this comment.
As far as I am aware, supporting this is not optional.
There was a problem hiding this comment.
That's a good point, the same is true for Vectors and we made a feature flag for those as well. It's mainly for development purposes, that way someone working on their 6.x branch won't start seeing red tests the moment we merge.
But it's worth considering if we want to use flags like that.
There was a problem hiding this comment.
I know. Personally, I would expect the driver to support both vectors and unsupported type so long as it claims support for Bolt 6.0.
robsdedude
reviewed
Sep 22, 2025
Co-authored-by: Robsdedude <[email protected]>
Co-authored-by: Robsdedude <[email protected]>
Co-authored-by: Robsdedude <[email protected]>
Co-authored-by: Robsdedude <[email protected]>
robsdedude
reviewed
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.